arsenm added a comment. In D69878#1805804 <https://reviews.llvm.org/D69878#1805804>, @arsenm wrote:
> In D69878#1801508 <https://reviews.llvm.org/D69878#1801508>, > @cameron.mcinally wrote: > > > This is looking pretty good to me, but I'm ignoring some of the target > > specific code that I'm not familiar with. > > > > Is `denormal-fp-math` influenced by `-Ofast`? Or are there plans for that? > > Seems like `-Ofast` should imply DAZ and FTZ (if supported by target). > > > Yes, through the toolchain handling. I copied the logic for when crtfastmath > is linked for the default mode for x86. > > > I think we discussed this before, but it's worth repeating. If > > `denormal-fp-math` isn't specified, we default to IEEE behavior, right? > > When this lands in master, there could be an unexpected performance hit for > > targets that aren't paying attention. E.g. I want to use `denormal-fp-math` > > to toggle whether a FSUB(-0.0,X) is converted to a FNEG(X) in > > SelectionDAGBuilder. > > > > Apologies in advance if this has been discussed recently. I've been > > distracted with another project for the passed few months... > > Yes, ieee should be the default. The dependent patches start adding the > attribute by default for platforms with flushing enabled with fast math To clarify this patch leaves the default and defers changing that to a later patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
