aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! ================ Comment at: clang/include/clang/Basic/Attr.td:2914 + let Spellings = [Declspec<"guard">]; + let Subjects = SubjectList<[Function]>; + let Args = [EnumArgument<"Guard", "GuardArg", ["nocf"], ["nocf"]>]; ---------------- ajpaverd wrote: > aaron.ballman wrote: > > Should we also support ObjC methods? What about things like lambdas or > > blocks? > > > > (Note, these could all be handled in a follow-up patch, I just wasn't > > certain if this attribute was specific to functions or anything that > > executes code.) > Good point! At the moment this attribute is only documented for functions, so > I'll have to investigate the expected behaviour for lambdas, blocks, and ObjC > methods and provide a follow-up patch. That sounds good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72167/new/ https://reviews.llvm.org/D72167 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
