JonasToth marked 3 inline comments as done.
JonasToth added inline comments.
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:4243
+ if (FProto) {
+ QualType ParamType = FProto->getParamType(ParamIndex);
+ if (ParamMatcher.matches(ParamType, Finder, &ParamMatches)) {
----------------
aaron.ballman wrote:
> Should we be canonicalizing this type as well?
I think here we shouldn't. In that case you could not match if e.g. the
parameter has a typedef. I think that would reduce possibilities for the
matcher usage.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72505/new/
https://reviews.llvm.org/D72505
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
