ffrankies added a comment. In D72239#1815583 <https://reviews.llvm.org/D72239#1815583>, @JonasToth wrote:
> The other recursion check seems more sophisticated. What is your take on it? > Would you consider it better as well, what is your opinion on it? I agree, I would go with the other check if I had to choose between the two. Since @lebedev.ri's version uses an existing CallGraph structure instead of re-creating it (like we did), I'd guess it is more performant than our version. Plus it doesn't have a user-defined recursion depth limit, which is one less thing for the user to worry about. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72239/new/ https://reviews.llvm.org/D72239 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
