craig.topper added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7061
+ auto pushOutChain = [this](auto &Result, auto EB) {
+ assert(Result.getNode()->getNumValues() == 2);
----------------
Why is Result a reference? It's not modified is it? Don't use auto for
parameter types. llvm coding style prefers auto to only be used when the type
is easily assumed by someone reading the code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72820/new/
https://reviews.llvm.org/D72820
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
