[PATCH] D72848: Remove some SVN-specific code.

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: clang/lib/Basic/Version.cpp:33
 #else
-  StringRef URL("");
+  return "";
 #endif
----------------
return {} should be better.


================
Comment at: clang/lib/Basic/Version.cpp:42
 #else
-  StringRef URL("");
+  return "";
 #endif
----------------
return {} should be better.


================
Comment at: clang/lib/Basic/Version.cpp:50
 #else
   return "";
 #endif
----------------
return {} should be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72848/new/

https://reviews.llvm.org/D72848



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits