hiraditya added inline comments.
================ Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:821 llvm::itostr(CGM.getCodeGenOpts().XRayInstructionThreshold)); + if (CGM.getCodeGenOpts().XRayIgnoreLoops) { + Fn->addFnAttr("xray-ignore-loops"); ---------------- we can remove braces here. ================ Comment at: clang/test/CodeGen/xray-ignore-loops.cpp:5 + return 1; +} + ---------------- I think we need one more test case of a function having a loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72873/new/ https://reviews.llvm.org/D72873 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits