evgeny777 added inline comments.
================ Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:762 + bool ReadOnly, bool WriteOnly, bool Constant, + GlobalObject::VCallVisibility Vis = GlobalObject::VCallVisibilityPublic) : MaybeReadOnly(ReadOnly), MaybeWriteOnly(WriteOnly), ---------------- I think using default parameter is error prone here. Can you please get rid of it and update all places of usage respectively? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71911/new/ https://reviews.llvm.org/D71911 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits