thakis marked an inline comment as done. thakis added inline comments.
================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3645 // CityHash, but this will do for now. hash_code code = hash_value(getClangFullRepositoryVersion()); ---------------- Arguably, we should omit the full repo version from the hash: There's no reason to use a new cache dir just because someone fixed a typo in the (say) mlir docs. We'd also be better about remembering to bump clang::serialization::VERSION_MAJOR/MINOR in that case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73202/new/ https://reviews.llvm.org/D73202 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
