steveire added a comment. In D73388#1840100 <https://reviews.llvm.org/D73388#1840100>, @rsmith wrote:
> This seems reasonable to me. > > If you want to unify something about this and the `Ignore*` functions in > `Expr`, maybe we could add a "classify" mechanism, so you could ask "what > kind of node is this?" and get back an enumerated value that indicates > whether it's semantic / syntactic / whatever. Then we could implement both > this and the downward-skipping in terms of that. That seems like a reasonable future refactoring yes. I agree we can progress with this patch for now though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73388/new/ https://reviews.llvm.org/D73388 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
