njames93 marked 3 inline comments as done. njames93 added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (void)(expr); +struct S {}; ---------------- gribozavr2 wrote: > njames93 wrote: > > gribozavr2 wrote: > > > Is the macro a necessary part of this test? If not, can it be removed? > > I like to stick to the bug report as much as possible > This is not generally the policy in LLVM and Clang. We prefer minimal > reproducers. I've kept it minimal, the REQUIRE definition is just to suppress other warnings about unused expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits