martong accepted this revision. martong added a comment. This revision is now accepted and ready to land.
Thanks for the patch! Looks good to me! ================ Comment at: clang/lib/AST/ASTImporter.cpp:192 + // Don't attempt to import nodes if we hit an error earlier. + if (Err) + return T{}; ---------------- Thanks for thinking about it. This way we can keep the original behavior i.e. the import is stopped on the first error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73667/new/ https://reviews.llvm.org/D73667 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits