[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaExpr.cpp:17183
+  class DeferredDiagnosticsEmitter
+      : public EvaluatedExprVisitor<DeferredDiagnosticsEmitter> {
+    Sema &S;
----------------
Is there any way to share most of the visitation logic here with the visitor we 
use in `MarkDeclarationsUsedInExpr`?  Maybe make a `UsedDeclVisitor` CRTP class 
that calls a "asImpl().visitUsedDecl(SourceLocation Loc, Decl *D)" in the right 
places?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70172/new/

https://reviews.llvm.org/D70172



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits