kmclaughlin marked 2 inline comments as done.
kmclaughlin added a comment.

Thanks for reviewing this @sdesmalen!



================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1116
+                 LLVMMatchType<0>,
+                 llvm_i32_ty],
+                [IntrNoMem]>;
----------------
sdesmalen wrote:
> missing ImmArg
This has been replaced with AdvSIMD_2VectorArgIndexed_Intrinsic, which it is 
the same as this but includes ImmArg<2>


================
Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1124
+                 LLVMMatchType<0>,
+                 llvm_i32_ty],
+                [IntrNoMem]>;
----------------
sdesmalen wrote:
> missing ImmArg
As above, but using AdvSIMD_3VectorArgIndexed_Intrinsic instead


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73636/new/

https://reviews.llvm.org/D73636



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to