Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
Cool, thanks you!
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:612
+ return !(Range.getBegin().isMacroID() || Range.getEnd().isMacroID());
+}
+
----------------
Side note: I like the other form of De Morgan's laws because here I have to
apply it in my head every time I see such a construct. Also we are using this
function in negation, so I would write:
```lang=c
static bool isMacro(const SourceRange &Range) {
return Range.getBegin().isMacroID() || Range.getEnd().isMacroID();
}
```
The idiom is to write code for readability so that understandability over
everything else.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73993/new/
https://reviews.llvm.org/D73993
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
