rjmccall added inline comments.
================ Comment at: clang/lib/CodeGen/CGCall.cpp:3697 + + args.add(EmitAnyExpr(E, ArgSlot), type); } ---------------- erik.pilkington wrote: > rjmccall wrote: > > If the argument type has a C++ destructor, will we end its lifetime before > > we call destructors at the end of the full-expression? > Yeah, this is broken :/ Well, we could at least do it for trivially-destructible types. That probably needs to include all kinds of non-trivial destructibility, not just C++, though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
