On Fri, Feb 07, 2020 at 07:12:39PM +0000, Nico Weber via Phabricator wrote: > thakis added a comment. > > This breaks check-clang on mac and win: > http://45.33.8.238/mac/7485/step_7.txt http://45.33.8.238/win/7753/step_7.txt > > Please revert and then investigate asynchronously, unless the fix is obvious. > > > > ================ > Comment at: clang/test/CodeGen/stack-clash-protection.c:2 > +// check interaction between -fstack-clash-protection and dynamic allocation > schemes > +// RUN: %clang -target x86_64 -O0 -o %t.out %s -fstack-clash-protection && > %t.out > + > ---------------- > Tests should compile binaries and then run them if at all possible. This is > impossible in cross-build scenarios and in general we try hard to have unit > tests, not integration tests. Check that this produces the IR you expect, and > have an llvm-level test that the IR produces the assembly you expect, and if > you must, an lld level test that checks that the generated elf file looks > like you think.
ok, thanks for the hint! Indeed I overlooked the cross compilation situation. Thanks for the hint and for reverting! _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
