MaskRay added a comment. If you don't mind, I can push a Diff to this Differential which will address these review comments.
================ Comment at: clang/lib/CodeGen/BackendUtil.cpp:436 + + std::ifstream fin(FunctionsListFile); + if (!fin.good()) { ---------------- `MemoryBuffer::getFile` avoid fstream. ================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:977 OPT_fno_unique_section_names, true); + Opts.UniqueBBSectionNames = Args.hasFlag( + OPT_funique_bb_section_names, OPT_fno_unique_bb_section_names, false); ---------------- This patch requires a rebase. `Opts.UniqueBBSectionNames = Args.hasArg(OPT_funique_bb_section_names);` -ffoo and -fno-foo should have a test/Driver/ test. There is no need to test both -ffoo and -fno-foo for cc1 options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits