hokein added a comment. > Also, the llvm::Twine fails too, many of the failures are related to the > forward declarations (I think the problem is that they are treated > differently from the original symbol and are not being renamed at all in the > corresponding files, but that's just my guess). It`s probably a good idea to > keep track of all the entries that can break global rename in some issue on > the Github so that they're not lost?
Yeap, that sounds good to me. Just create an issue, and put all details there, attach the detailed log would be helpful. I suspect we may encounter bugs in xrefs/rename code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits