sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/Protocol.h:1100 + /// NOTE: This excludes fuzzy matching score which is typically calculated on + /// the client side. + float score = 0.f; ---------------- /// This is a clangd extension. ================ Comment at: clang-tools-extra/clangd/test/completion-auto-trigger.test:27 # CHECK-NEXT: "label": " size", +# CHECK-NEXT: "score": 13.200000762939453, # CHECK-NEXT: "sortText": "{{.*}}size", ---------------- let's not include the value (note we don't in sortText either, which contains the encoded float) Use `{{.*}}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74547/new/ https://reviews.llvm.org/D74547 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits