kadircet added a comment.
some drive-by comments:
if this is a client-specific option, wouldn't it be equally hard for client to
just set this in the LSP layer, instead of telling clangd to do that?
by looking at the current patch, it rather seems like a user-specific option,
which will help users who want to prevent their editors from re-ranking results.
================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:983
+ LSPList.isIncomplete =
+ ClangdServerOpts.AlwaysIncomplete ? true
+ : List->HasMore;
----------------
nit: `ClangdServerOpts.AlwaysIncomplete || List->HasMore`
================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:405
+opt<bool> AlwaysIncomplete{
+ "always-incomplete",
----------------
if we want clients to set it wouldn't it be better to make it an
`initialization` option instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74555/new/
https://reviews.llvm.org/D74555
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
