aaron.ballman added a comment.

In http://reviews.llvm.org/D16376#360527, @jbcoe wrote:

> The Sema diagnostic warning is only produced if a deprecated special member 
> function is used whereas I want to find places where it would be 
> compiler-generated and explicitly delete them. This is useful for library 
> code where I don't have control over the warnings my users will run with.
>
> The AST Matcher I use are simple enough and I'm not convinced that it's worth 
> refactoring Sema to expose what I need. If someone (Richard?) with a deeper 
> understanding can point me in the right direction I'm happy to be corrected.
>
> SemaDeclCXX.cpp `diagnoseDeprecatedCopyOperation` is producing Sema's 
> diagnostics.


I'm on the fence about whether this functionality should be in both clang-tidy 
and Sema, but lean towards leaving it separated because of your use case as a 
library author. However, that suggests perhaps it should be under the modernize 
umbrella instead of misc because already-modern code shouldn't be using 
deprecated functionality. Also, the documentation should probably spell out 
that this differs from warn_deprecated_copy_operation, how it differs, and why 
that's useful.


http://reviews.llvm.org/D16376



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to