rjmccall added a comment. The C diagnostic changes seem like improvements, yeah. The virtue of re-using the same infrastructure across language modes.
================ Comment at: clang/lib/Sema/SemaExprCXX.cpp:3880 + ToType, From->getType(), From, Action); + // assert(Diagnosed && "failed to diagnose bad conversion"); + (void)Diagnosed; ---------------- This assertion seems important; can we make it work? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74116/new/ https://reviews.llvm.org/D74116 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
