njames93 added a comment.

I have a feeling this check should be called something along the lines of 
bugprone-suspicous-include.



================
Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:62
+      Check.diag(HashLoc, "suspicious #include")
+          << FixItHint::CreateReplacement(FilenameRange,
+                                          ((IsAngled ? "<" : "\"") + FileName +
----------------
This replacement is dangerous, I have a feeling no fix-it should be provided or 
at least do a search of the include directories to see if file you are trying 
to include actually does exist. The correct file could be `*.hpp` like what 
boost uses for all its header files


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74669/new/

https://reviews.llvm.org/D74669



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to