Mordante marked 2 inline comments as done. Mordante added a comment. Herald added a subscriber: martong.
Thanks for the review. I'll have a look at your suggestion for a follow-up patch. ================ Comment at: clang/test/Sema/cast.c:1 -// RUN: %clang_cc1 -fsyntax-only -triple x86_64-unknown-unknown %s -verify +// RUN: %clang_cc1 -fsyntax-only -triple x86_64-unknown-unknown -Wpointer-to-int-cast %s -verify ---------------- rsmith wrote: > Don't specify the warning flag here, so that we have some test coverage that > this is enabled by default. Good catch! This was needed before the diagnostic was enabled by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
