SjoerdMeijer added inline comments.
================ Comment at: clang/test/Driver/arm-cde.c:12 + +// RUN: %clang -target arm-none-none-eabi -march=armv8m.main+cdecp0+cdecp3 %s -### -c 2>&1 | FileCheck %s --check-prefix=CHECK-CDE1 +// CHECK-CDE1: "-triple" "thumbv8m.main-none-none-eabi" ---------------- Probably good to add a test for v8.1-M too, and also with MVE ================ Comment at: llvm/lib/Target/ARM/ARMInstrCDE.td:1 +// Immediate operand of arbitrary bit width +class BitWidthImmOperand<int width> ---------------- This file needs the copyright header ================ Comment at: llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp:8161 + case ARM::t2CDP: case ARM::t2CDP2: + case ARM::t2LDC2L_OFFSET: case ARM::t2LDC2L_OPTION: case ARM::t2LDC2L_POST: case ARM::t2LDC2L_PRE: + case ARM::t2LDC2_OFFSET: case ARM::t2LDC2_OPTION: case ARM::t2LDC2_POST: case ARM::t2LDC2_PRE: ---------------- clang-format this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74044/new/ https://reviews.llvm.org/D74044 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits