steven_wu added a comment. I forgot if there is reason to use the option by default at all time (I did ask that in the previous review but Alex might have given more context offline).
You should definitely add test for this change. The fact that you change all `-mlinker-version=400` to `-mlinker-version=0` but not change any CHECK lines means the change is definitely not tested :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/new/ https://reviews.llvm.org/D74784 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
