thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Thanks! Does this make it so that libclang.dll is built again with
-DLLVM_ENABLE_PIC=NO on Window? From what I understand, it doesn't. Is that
correct? If so, could you reinstantiate that too?
================
Comment at: clang/include/clang-c/Platform.h:33
#endif
-#elif defined(CINDEX_EXPORTS)
+#elif defined(CINDEX_EXPORTS) && defined(__GNUC__)
#define CINDEX_LINKAGE __attribute__((visibility("default")))
----------------
Why is this change necessary?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74907/new/
https://reviews.llvm.org/D74907
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
