cchen marked an inline comment as done. cchen added a comment. In D74970#1887193 <https://reviews.llvm.org/D74970#1887193>, @ABataev wrote:
> Did you try to run the tests? I would suggest adding a test, at least, where > a function is mapped. We should see the error message here. Seems to me, we > don't have this one. We already have test for `err_omp_invalid_map_this_expr`, `note_omp_invalid_subscript_on_this_ptr_map`, etc.. in target_message.cpp line 44 without checking for value dependence. Do you mean that I should add a test for the check of value dependence? In that case, we don't print any messages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74970/new/ https://reviews.llvm.org/D74970 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
