dblaikie added a comment. In D74846#1888410 <https://reviews.llvm.org/D74846#1888410>, @llunak wrote:
> Upon further investigation it turns out I probably should not have enabled > those two places for PCH in D69778 <https://reviews.llvm.org/D69778> at all, > since they do not deal with -fmodules-codegen. So reverting those two places > should be the right fix. That also makes a test irrelevant (not much point in > testing a rare corner-case for a code path never taken). I know it's a bit of an awkward situation to test - but please include one to demonstrate why the original code was inappropriate. At least useful for reviewing/validating the patch, but also might help someone else not to make the same change again in the future. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74846/new/ https://reviews.llvm.org/D74846 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
