shafik added a comment.
A few comments and I would like @teemperor to give this a look as well but it
looks good to me.
================
Comment at: clang/lib/AST/ASTImporter.cpp:3281
+ // Import the function parameters.
+ SmallVector<ParmVarDecl *, 8> Parameters;
----------------
I am curious, why move this chunk of code up?
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5850
+
+TEST_P(ImportTypeLoc, Function) {
+ Decl *FromTU = getTuDecl(
----------------
Maybe I am missing it but these tests don't seem like they cover all the visit
methods of `TypeLocImporter`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71018/new/
https://reviews.llvm.org/D71018
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
