NoQ accepted this revision. NoQ added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:92 + + bool IncludePath = false, ShouldEmitAsError = false, FixitsAsRemarks = false, + ApplyFixIts = false; ---------------- Charusso wrote: > NoQ wrote: > > Charusso wrote: > > > NoQ wrote: > > > > I'll be perfectly happy with removing `FixitsAsRemarks` entirely. Your > > > > new mechanism is superior. > > > Okai, challenge accepted. Thanks! > > So, can we remove `FixitsAsRemarks` now or is anything still blocking it? > https://reviews.llvm.org/D73729 Oh crap, how did i miss this? Thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
