Charusso added a comment.

I am so sorry to mention, but we need the `AnalysisManager` to pass around 
which manages the analysis, therefore it knows both the `LangOptions` and 
`AnalyzerOptions`. Also this entire callback should be removed ideally: it has 
to be a virtual function defaulting to `return true;` and if someone needs this 
feature could rewrite the behavior. I guess there was some debate whether it 
should be on by default or not, but for a checker writer and future changes 
this patch shows that how weak this API is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75271/new/

https://reviews.llvm.org/D75271



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to