ldionne added a comment.

In D73245#1894420 <https://reviews.llvm.org/D73245#1894420>, @EricWF wrote:

> @ldionne Since this has the possibility of breaking existing users of 
> `std::max_align_t`, can you test this against your c++03 codebases?


I have no opinion about this patch, but I generally agree we shouldn't make 
efforts to provide C++03 conformance. It's a vain effort and we should be 
looking towards the future. On the other hand, this patch does seem to simplify 
the code a bit, in the sense that we now don't provide anything unless we have 
a conforming C++11 implementation, in which case we don't need to go through 
platform specific hoops anymore. I like that.

Regardless, I'm running this change on a code base to see whether it causes 
problems.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73245/new/

https://reviews.llvm.org/D73245



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to