EricWF added a comment.
LGTM once all of the inline comments are addressed.
After that, this is ready to land.
================
Comment at: clang/lib/AST/ItaniumMangle.cpp:3412
break;
+ case UnaryTransformType::RemoveReferenceType:
+ Out << "3err";
----------------
zoecarver wrote:
> Eric, I looked at your comment, but it seems that we no longer unary type
> transformations that way. @rsmith is this correct?
@rsmith Can you double check the mangling changes?
================
Comment at: clang/lib/Sema/SemaType.cpp:1624
}
+ case DeclSpec::TST_removeReferenceType:
+ case DeclSpec::TST_removeCV:
----------------
Why can't we share the implementation with `TST_underlyingType`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D67052/new/
https://reviews.llvm.org/D67052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
