jroelofs marked 2 inline comments as done. jroelofs added a comment. In D74669#1902107 <https://reviews.llvm.org/D74669#1902107>, @njames93 wrote:
> Adding the parent revision means you don't need to have those changes in this > patch. IIUC, that is what I've already done: https://reviews.llvm.org/D74669 is `git show c4dd6f5903e -U999` https://reviews.llvm.org/D75489 is `git show 0cda7e0b9ed -U999` where `c4dd6f5903e` is the parent of `0cda7e0b9ed`. The suggestion to switch over to `;`s as delimiters is what's causing this diff to still touch so many files. ================ Comment at: clang-tools-extra/clang-tidy/bugprone/DynamicStaticInitializersCheck.h:24 +/// extensions of header files (The filename extensions should not contain +/// "." prefix). "h;hh;hpp;hxx" by default. +// ---------------- ";h;hh;hpp;hxx" ================ Comment at: clang-tools-extra/clang-tidy/google/UnnamedNamespaceInHeaderCheck.h:25 +/// extensions of header files (The filename extensions should not contain +/// "." prefix). "h;hh;hpp;hxx" by default. +/// ---------------- ";h;hh;hpp;hxx" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
