nickdesaulniers added inline comments.
================
Comment at: clang/test/Parser/asm-qualifiers.c:20
+
+void combinations(void) {
+ asm volatile inline("");
----------------
nathanchance wrote:
> I'm probably being dense but what is intended to be tested differently
> between `combinations` and `permutations`? I assume the order of the
> qualifiers? Wouldn't it just be better to merge `combinations` into
> `permutations` or was there some deeper reasoning for the
> compartmentalization?
`combinations` tests a combination of different `asm-qualifiers` together.
`permutations` are just permutations of the combinations that have not been
tested above. I may not even have my nomenclature correct. Shall I combine
them?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75563/new/
https://reviews.llvm.org/D75563
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
