kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdServer.h:73
virtual void onDiagnosticsReady(PathRef File,
+ const llvm::json::Value &Version,
std::vector<Diag> Diagnostics) {}
----------------
sammccall wrote:
> kadircet wrote:
> > can we rather have `Optional<int>`s here(both for callbacks and
> > `addDocument`)?
> >
> > as clangdserver layer doesn't touch json objects at all currently.
> I really do want to make these opaque at the lower layer.
> json is a bit fiddly though, reworked to use strings instead.
looks better thanks !
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75582/new/
https://reviews.llvm.org/D75582
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
