kadircet added a comment. In D75603#1906418 <https://reviews.llvm.org/D75603#1906418>, @sammccall wrote:
> Forgot to mention: I also think the trace approach certainly has things going > for it, or even parsing out the messages from the existing logs. > But in this particular case the callback happens to be extremely convenient > and also not invasive (since the data structures are already exposed, code > complete has an opts struct etc). And since this is for analysis we have a > lot of flexibility to rework if it stops being easy to maintain. as discussed offline, I was rather afraid of the initial version of the patch, but the final version seems ok as it only adds a single field to codecompleteopts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75603/new/ https://reviews.llvm.org/D75603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
