mwyman marked 6 inline comments as done.
mwyman added inline comments.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/objc-method-unavailable-not-override.m:34
+// Verify check when using a macro that expands to the unavailable attribute.
+- (void)methodC NS_UNAVAILABLE;
+// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: method 'methodC' is marked
unavailable but does not override a superclass method
[objc-method-unavailable-not-override]
----------------
njames93 wrote:
> Generally we are cautious about modifying MACRO usages in clang_tidy as we
> don't know if its definition can change based on configuration, perhaps its
> safer to just warn instead of providing a fix it
Sounds reasonable; I made this the default behavior.
However for Objective-C, it's quite common for developers to use a macro from
the Apple SDKs like NS_UNAVAILABLE that are unconditional in any situations I
know of. I added a config option to allow whitelisting macros that should have
fix-its provided.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/objc-method-unavailable-not-override.m:51
+// Verify that fixes exist to delete entire method declarations:
+// CHECK-FIXES: {{^\s*$}}
----------------
njames93 wrote:
> This is not a satisfactory check, it will ensure at least one method has been
> deleted but it wont ensure all methods have been deleted. Would probably be
> safer putting a unique comment on the line and having a check fix that checks
> for an empty line and the comment for each case.
Thanks for the suggestion! Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75569/new/
https://reviews.llvm.org/D75569
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
