kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @efriedma!
================ Comment at: clang/lib/Basic/Targets/AArch64.h:95 + case 'U': // Three-character constraint; add "@3" hint for later parsing. + R = std::string("@3") + std::string(Constraint, 3); + Constraint += 2; ---------------- efriedma wrote: > Is "@3" some LLVM thing? I don't think I've seen it before. The "@" is used to indicate that this is a multi-letter constraint of a given length. This is parsed later by InlineAsm.cpp, see https://reviews.llvm.org/D66524 ================ Comment at: clang/test/CodeGen/aarch64-sve-inline-asm-datatypes.c:2 +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns \ +// RUN: -target-feature +neon -S -O1 -o - %s | FileCheck %s + ---------------- efriedma wrote: > `REQUIRES: aarch64-registered-target` is necessary for any test that isn't > using -emit-llvm. > > Generally, I'd prefer tests using -emit-llvm so we can independently verify > that the IR is what we expect, vs. the backend processing the IR the way we > expect. I've added -emit-llvm here and updated the CHECK lines accordingly CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75690/new/ https://reviews.llvm.org/D75690 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits