baloghadamsoftware marked 4 inline comments as done. baloghadamsoftware added inline comments.
================ Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:519-520 +const NoteTag *IteratorModeling::getChangeTag(CheckerContext &C, StringRef Text, + const Expr *ItE, SVal It1, + int64_t Amount, SVal It2) const { + StringRef Name; ---------------- Szelethus wrote: > Szelethus wrote: > > Are `It1` and `It2` used? Why do we default the latter to `UndefinedVal`? > Ah, okay, we use it in a followup patch. Still, we shouldn't use > `UndefinedVal`, as discussed in D75514. I completely removed them from this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74541/new/ https://reviews.llvm.org/D74541 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits