kadircet added a comment.

In D75446#1924496 <https://reviews.llvm.org/D75446#1924496>, @sammccall wrote:

> I think per offline discussion, this was going to have some additional docs 
> clarifying the contracts of this function, and maybe extra tests?
>
> The conclusion IIRC was that this function is designed to find the text that 
> you could replace in order to replace an AST node, so it's fairly 
> conservative (but arg expansions are fair game assuming expanded once).


Right, I just didn't get a chance to look at it again. Planning to do that once 
I've got some cycles.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75446/new/

https://reviews.llvm.org/D75446



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to