tmsriram marked an inline comment as done. tmsriram added inline comments.
================ Comment at: clang/test/CodeGen/unique-internal-funcnames.c:3 + +// RUN: %clang -target x86_64 -S -o - %s | FileCheck %s --check-prefix=PLAIN +// RUN: %clang -target x86_64 -S -funique-internal-funcnames -o - %s | FileCheck %s --check-prefix=UNIQUE ---------------- davidxl wrote: > MaskRay wrote: > > You can hardly find any .c -> .s test in clang/test. We mostly do .c -> .ll > > testing. `.ll` -> `.s` are in llvm/test/CodeGen. > Is this convention documented somewhere? Any concerns of producing .s? There are more than 200 tests in clang that do -S from .c -> .s and tens of tests in CodeGen alone. I can change this to .ll but curious where this "hardly any" comes from? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
