aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some small nits! ================ Comment at: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt:15 clangTooling + clangTidyPortabilityModule ) ---------------- Can you keep this list sorted in alphabetical order? ================ Comment at: clang-tools-extra/clang-tidy/portability/RestrictSystemIncludesCheck.h:85 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_PORTABILITY_RESTRICTINCLUDESSCHECK_H \ No newline at end of file ---------------- Can you add a newline to the end of the file (as a drive-by)? ================ Comment at: clang-tools-extra/docs/clang-tidy/checks/llvmlibc-restrict-system-libc-headers.rst:32 + + This can be used to whitelist known safe includes such as Linux development + headers. See :doc:`portability-restrict-system-includes ---------------- whitelist -> allow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76395/new/ https://reviews.llvm.org/D76395 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
