jhenderson accepted this revision. jhenderson added a comment. LGTM, with nit, with regards to the llvm-readobj and libObject parts. I haven't looked at the other bits though.
================ Comment at: llvm/lib/CodeGen/AsmPrinter/OcamlGCPrinter.cpp:150 + ">= 65536.\n" + "(" + + Twine(reinterpret_cast<uintptr_t>(&FI)) + ")"); ---------------- Nit: I think you can fold these two string literals together. Not sure why they were separate before. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76572/new/ https://reviews.llvm.org/D76572 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits