erichkeane marked 3 inline comments as done. erichkeane added a comment. Both done here: fe5c719eaf572e23b700e75832ec37a3761b337b <https://reviews.llvm.org/rGfe5c719eaf572e23b700e75832ec37a3761b337b> . Thanks for the review @Anastasia
================ Comment at: clang/test/CodeGenOpenCL/pipe_types_mangling.cl:12 +// WINDOWS: define dso_local void @"?test1@@YAXU?$ocl_pipe@H$00@__clang@@@Z" +// UNMANGLED: define {{.*}}void @test1( +} ---------------- Anastasia wrote: > erichkeane wrote: > > Anastasia wrote: > > > Any reason to test unmangled? > > Because you asked to validate the OpenCL cases as well. > Ok, I guess we should add overloadable attribute otherwise it doesn't go > through mangling? Then I guess you only need a check for Linux or Windows > cases. Done, I wasn't able to remove OCLWINDOWS, since windows mangles attribute 'overloadable' in C only (and thus OpenCL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75685/new/ https://reviews.llvm.org/D75685 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits