dblaikie added a comment.

@gribozavr2 - hey, an annoying quirk of Phabricator is that it doesn't send 
mail to the mailing list on state changes with no text, which means reviews 
like these look like tehy were committed without approval (on the mailing list 
there's no record of the approval). In the future, can you add some comment to 
your approval ("Looks good", "thanks", etc) to ensure mail is sent to the 
mailing list to document that approval there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74934/new/

https://reviews.llvm.org/D74934



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to