phosek added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:143
+ if (llvm::sys::path::is_relative(SysRoot)) {
+ // Prepend InstalledDir if SysRoot is relative
----------------
Does this return `true` or `false` when sysroot is empty?
================
Comment at: clang/lib/Driver/Driver.cpp:145
+ // Prepend InstalledDir if SysRoot is relative
+ SmallString<128> fullpath(InstalledDir);
+ llvm::sys::path::append(fullpath, SysRoot);
----------------
Nit: according to LLVM conventions, this should `FullPath` (or just `P` which
is also very common temporary path variables).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76653/new/
https://reviews.llvm.org/D76653
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
