balazske marked an inline comment as done. balazske added inline comments.
================ Comment at: clang/test/Analysis/kmalloc-linux-1.c:15 + +// FIXME: malloc checker expects kfree with 2 arguments, is this correct? +// (recent kernel source code contains a `kfree(const void *)`) ---------------- Szelethus wrote: > balazske wrote: > > Szelethus wrote: > > > martong wrote: > > > > Do you plan to sniff around a bit about the arguments (as part of > > > > another patch)? Would be good to handle both old and new signature > > > > kernel allocation functions. > > > I'll take a quick look as well, I am quite familiar with MallocChecker. > > I found that `kfree` has one argument, not two (even in the 2.6 kernel). > > Probably argument count was wrong in the last change when `CallDescription` > > was introduced. > Yup, you're totally right, this was on me :) I'll get that fixed. Is it better to add these tests to **kmalloc-linux.c**? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76830/new/ https://reviews.llvm.org/D76830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
